[PATCH] ARM: generation of .ARM.exidx/.ARM.extab sections

Leny Kholodov leny.kholodov at gmail.com
Tue May 5 08:35:09 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/Core/DefinedAtom.cpp:46
@@ -45,2 +45,3 @@
   case typeNoAlloc:
+  case typeARMExidx:
     return permR__;
----------------
denis-protivensky wrote:
> Just a general note to think about:
> 
> Maybe it's a good time to introduce `doPermissions` method for descendants and handle specific types there?
I agree but I believe it should be implemented as separate patch.

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMELFFile.h:33
@@ +32,3 @@
+
+    return ELFDefinedAtom<ELF32LE>::permissions();
+  }
----------------
denis-protivensky wrote:
> This should work as `ELFDefinedAtom::permissions()`. Please, check it.
I'll move the implementation to ELFDefinedAtom.

http://reviews.llvm.org/D9324

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list