[PATCH] Enable YAMLParser tests (They were never enabled and never ran it seems)

Justin Bogner mail at justinbogner.com
Mon May 4 13:29:09 PDT 2015


Alex Lorenz <arphaman at gmail.com> writes:
> I've renamed the test files - now they use the 'test' extension
> instead of the old 'data' extension, so now 'lit.cfg'
> doesn't have to be modified.
>
> I've modified yaml-bench so that it would return an error status if an
> error occurred during parsing.
> I've also added the '-use-color' command line option to yaml-bench (To
> make file check matches error messages in the output stream).
>
> I've also adjusted some tests - got rid of unnecessary XFAILs and used
> not instead where appropriate. A couple of tests are also passing
> when they shouldn't be, the yaml parser is incomplete and has some
> bugs that will have to be fixed.

Please use clang-format. Some of the indentation in this patch is a
little unusual. Also, in a couple of the tests you've added "FIXME: This
test should fail." without any further explanation. Please be a little
more specific in these comments (ie, "yaml-bench should exit with an
error", or "the output should be xyz"), or write the test to pass for
the correct output and leave the XFAIL in place (then they'll XPASS when
the bug is fixed).



More information about the llvm-commits mailing list