[PATCH] Add a shrink-wrapping pass to improve the placement of prologue and epilogue.

[Kristof Beyls]

Hi Quentin,

As far as I can see, the only comment made that hasn't been addressed yet
is about renaming/replacing EntryBlock and ReturnBlocks in class PEI with
SaveBlock/RestoreBlocks. It seems PEI only needs to know what the Save and
Restore blocks are, and doesn't need to know which ones are the Entry or
Return blocks. Therefore, it doesn't seem a good idea to retain the EntryBlock
and ReturnBlocks variables in that class. But maybe you already looked
into that and there's a reason why EntryBlock and ReturnBlocks is needed
after all?

Apart from the above comment, which I think needs to be addressed, the patch
looks good to me.

Thanks,

Kristof

> -----Original Message-----
> From: Quentin Colombet [mailto:qcolombet at apple.com]
> Sent: 04 May 2015 18:51
> To: qcolombet at apple.com; grosbach at apple.com
> Cc: kparzysz at codeaurora.org; Kristof Beyls; dberlin at dberlin.org; Amara
> Emerson; justin.holewinski at gmail.com; llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] Add a shrink-wrapping pass to improve the placement
> of prologue and epilogue.
> 
> Ping?
> 
> Thanks,
> -Quentin
> 
> 
> http://reviews.llvm.org/D9210
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>