[llvm] r236003 - R600/SI: Add a lower case alias for subtarget feature: +DumpCode

Tom Stellard tom at stellard.net
Mon May 4 09:54:39 PDT 2015


On Tue, Apr 28, 2015 at 05:58:51PM +0000, Eric Christopher wrote:
> Does this really need to be a subtarget feature? It's weird and seems like
> it should just be a command line option.
> 

It could be a command line option.  I will look into this.

-Tom

> -eric
> 
> On Tue, Apr 28, 2015 at 10:48 AM Tom Stellard <thomas.stellard at amd.com>
> wrote:
> 
> > Author: tstellar
> > Date: Tue Apr 28 12:37:00 2015
> > New Revision: 236003
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=236003&view=rev
> > Log:
> > R600/SI: Add a lower case alias for subtarget feature: +DumpCode
> >
> > llc converts all feature strings to lower case, while the LLVM C API
> > does not, so we need a lower case alias in order to test this with llc.
> >
> > Modified:
> >     llvm/trunk/lib/Target/R600/AMDGPU.td
> >
> > Modified: llvm/trunk/lib/Target/R600/AMDGPU.td
> > URL:
> > http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPU.td?rev=236003&r1=236002&r2=236003&view=diff
> >
> > ==============================================================================
> > --- llvm/trunk/lib/Target/R600/AMDGPU.td (original)
> > +++ llvm/trunk/lib/Target/R600/AMDGPU.td Tue Apr 28 12:37:00 2015
> > @@ -20,6 +20,11 @@ def FeatureDumpCode : SubtargetFeature <
> >          "true",
> >          "Dump MachineInstrs in the CodeEmitter">;
> >
> > +def FeatureDumpCodeLower : SubtargetFeature <"dumpcode",
> > +        "DumpCode",
> > +        "true",
> > +        "Dump MachineInstrs in the CodeEmitter">;
> > +
> >  def FeatureIRStructurizer : SubtargetFeature <"disable-irstructurizer",
> >          "EnableIRStructurizer",
> >          "false",
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list