3.6.1 patches - fixes for crashes

Nick Lewycky nicholas at mxc.ca
Sun May 3 18:18:49 PDT 2015


Richard Smith wrote:
> On Fri, May 1, 2015 at 6:24 PM, Richard Trieu <rtrieu at google.com
> <mailto:rtrieu at google.com>> wrote:
>
>     Tom,
>
>     These are patches that fix crashes that I have encountered while
>     working on Clang.  I believe that they would be good for 3.6.1.  I
>     included revision numbers, bug reports, and authors below.
>
>     These two patches fix crash on invalids involving template diffing.
>     r226983 - PR21758 (rtrieu)
>     r230603 - PR22017 (rtrieu)
>
>     Other small patches that fix crashes.  Patch authors CCed
>     r232425 - (rtrieu)
>     r232449 - PR22929 (dexonsmith)
>     r232579 - PR22940 (nicholas)
>     r232675 - PR22931 (rtrieu)
>     r232786 - PR22959 (majnemer)
>     r232794 - PR22960 (nicholas)
>
>
> Hi Tom,
>
> All of the above are approved for branch other than nicholas'  r232579

r232579 is a clang irgen change with no llvm component. I'd like someone 
familiar with clang to sign off.

> and r232794 -- those are LLVM changes, you'll need someone else to sign
> off on those.

r232794 is really quite safe, I'd sign off on it. Looking at code 
owners, this would appear to not match anything before Chris Lattner's 
fallback entry.

Nick



More information about the llvm-commits mailing list