3.6.1 patch nomination: r227503 and rL227519 (fix win64 allocas)

Tom Stellard tom at stellard.net
Fri May 1 21:29:42 PDT 2015


Hi Tony,

r227503 has been merged as r236302
r227519 has been merged as r236378
r227574 has been merged as r236379

-Tom

On Tue, Apr 28, 2015 at 12:58:29AM -0700, Tony Kelman wrote:
> Wanted to double-check that this hasn't been forgotten about. I don't see 
> any signs of these having been backported yet to 
> https://github.com/llvm-mirror/llvm/commits/release_36.
> 
> Thanks,
> Tony
> 
> 
> -----Original Message----- 
> From: Nadav Rotem
> Sent: Friday, April 17, 2015 12:17 PM
> To: Tom Stellard
> Cc: Reid Kleckner ; Isaiah Norton ; llvm-commits ; Reid Kleckner ; Keno 
> Fischer ; Tony Kelman ; Jameson Nash
> Subject: Re: 3.6.1 patch nomination: r227503 and rL227519 (fix win64 
> allocas)
> 
> 
> 
> > On Apr 17, 2015, at 10:22 AM, Tom Stellard <tom at stellard.net> wrote:
> >
> > Nadav,
> >
> > Are these patches OK to merge to the 3.6 branch:
> 
> Yes. Reid reviewed the code, and the fix is specific for windows. Lets merge 
> them into 3.6.
> 
> 
> >
> > http://reviews.llvm.org/rL227503
> > http://reviews.llvm.org/rL227519
> >
> > -Tom
> >
> > On Wed, Apr 15, 2015 at 08:15:46AM -0700, Reid Kleckner wrote:
> >> These are good bugfixes, so I support merging them to 3.6.1.
> >>
> >> On Sun, Apr 12, 2015 at 6:19 PM, Isaiah Norton <isaiah.norton at gmail.com>
> >> wrote:
> >>
> >>> Hi,
> >>>
> >>> Please consider backporting the recent win64 alloca fixes to 3.6.1:
> >>>
> >>> http://reviews.llvm.org/rL227503
> >>> http://reviews.llvm.org/rL227519
> >>>
> >>> Julia is now carrying these against 3.6.0 because Fortran calling is
> >>> broken otherwise. With the patches, all of our FFI-based regression 
> >>> tests
> >>> pass on Windows.
> >>>
> >>> Thanks,
> >>> Isaiah
> >>>
> >>> _______________________________________________
> >>> llvm-commits mailing list
> >>> llvm-commits at cs.uiuc.edu
> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >>>
> >>>
> 



More information about the llvm-commits mailing list