[PATCH] R600/SI: Fix verifier errors from the SIAnnotateControlFlow pass

Matt Arsenault Matthew.Arsenault at amd.com
Thu Apr 30 16:41:59 PDT 2015


On 04/30/2015 01:12 PM, Tom Stellard wrote:
> This pass was generating 'Instruction does not dominate all uses!'
> errors for programs which had loops with a condition variable that
> depended on the result of a phi instruction from outside of the loop.
>
> The pass was inserting new phi nodes outside of the loop which used values
> defined inside the loop.
>
> http://bugs.freedesktop.org/show_bug.cgi?id=90056
> ---
>   lib/Target/R600/SIAnnotateControlFlow.cpp | 10 +++++++-
>   test/CodeGen/R600/si-annotate-cf.ll       | 38 +++++++++++++++++++++++++++++++
>   2 files changed, 47 insertions(+), 1 deletion(-)

LGTM



More information about the llvm-commits mailing list