[PATCH] Add support for running lldb-test on android targets

[Siva Chandra]

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:475
@@ +474,3 @@
+# for cmake and compile
+def getLLDBCmakeCompileSteps(f,
+                             build_compiler,
----------------
sivachandra wrote:
> chying wrote:
> > sivachandra wrote:
> > > I think this function can be named getLLDBAndroidCmakeStep and decoupled with compilation step. Non-Android cmake step can be as before. See my comments below.
> > This function contains both steps, because cmake and compilation step will always be called together for local configuration first, and then once for each target platform. If compilation step is decoupled, then we need to have the same code for compilation step in multiple places.
> OK. Then I suggest 1. Rename getLLDBCmakeCompileSteps to getLLDBCMakeAndCompileSteps. 2. Add these functions:
> 
>   def getLLDBCMakeStep(...):
>     if ... == 'linux':
>       getLLDBLinuxCMakeStep(...)
>     elif ... == 'android':
>       getLLDBAndroidCMakeStep(...)
> 
>   def getLLDBLinuxCMakeStep(...):
>     ...
> 
>   def getLLDBAndroidCMakeStep(...):
>     ...
>       
Sorry, forgot to mention that you should call getLLDBCMakeStep from getLLDBCMakeAndCompileSteps.

http://reviews.llvm.org/D9354

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/