[compiler-rt] r235961 - Address old FIXMEs in UBSan test cases.

[Alexey Samsonov]

(sigh) reverted to XFAIL again in r236165. Kuba, could you take a look at
why UBSAN_OPTIONS=print_stacktrace=1 doesn't trigger printing a stacktrace
on Darwin?

On Wed, Apr 29, 2015 at 1:46 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:

> I've submitted r236152 that improves the test case and once again removes
> XFAIL:darwin. Watching the bot (
> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/).
>
> On Wed, Apr 29, 2015 at 11:41 AM, Alexey Samsonov <vonosmas at gmail.com>
> wrote:
>
>>
>> On Wed, Apr 29, 2015 at 10:52 AM, Ahmed Bougacha <
>> ahmed.bougacha at gmail.com> wrote:
>>
>>> I went ahead and XFAIL-ed vptr.cpp in r236135,
>>
>>
>> Sure, thank you! Sorry for the breakage.
>>
>>
>>> let me know if you need
>>> help reproducing.
>>>
>>
>> I think I know what the issue is (UBSan on Mac doesn't support weak
>> hooks). I'll get back to you and ask to test the patch shortly.
>>
>>
>>>
>>> -Ahmed
>>>
>>>
>>> On Tue, Apr 28, 2015 at 5:41 PM, Ahmed Bougacha
>>> <ahmed.bougacha at gmail.com> wrote:
>>> > On Mon, Apr 27, 2015 at 6:29 PM, Alexey Samsonov <vonosmas at gmail.com>
>>> wrote:
>>> >> Author: samsonov
>>> >> Date: Mon Apr 27 20:29:36 2015
>>> >> New Revision: 235961
>>> >>
>>> >> URL: http://llvm.org/viewvc/llvm-project?rev=235961&view=rev
>>> >> Log:
>>> >> Address old FIXMEs in UBSan test cases.
>>> >>
>>> >> Modified:
>>> >>     compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp
>>> >>     compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp
>>> >>
>>> >> Modified:
>>> compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp
>>> >> URL:
>>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp?rev=235961&r1=235960&r2=235961&view=diff
>>> >>
>>> ==============================================================================
>>> >> --- compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp
>>> (original)
>>> >> +++ compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp
>>> Mon Apr 27 20:29:36 2015
>>> >> @@ -1,4 +1,3 @@
>>> >> -// FIXME: run this (and other) UBSan tests in both 32- and 64-bit
>>> modes (?).
>>> >>  // RUN: %clangxx -fsanitize=float-cast-overflow -g %s -o %t
>>> >>  // RUN: %run %t _
>>> >>  // RUN: env UBSAN_OPTIONS=print_summary=1 %run %t 0 2>&1 | FileCheck
>>> %s --check-prefix=CHECK-0
>>> >>
>>> >> Modified: compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp
>>> >> URL:
>>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp?rev=235961&r1=235960&r2=235961&view=diff
>>> >>
>>> ==============================================================================
>>> >> --- compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp
>>> (original)
>>> >> +++ compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp Mon Apr
>>> 27 20:29:36 2015
>>> >> @@ -23,8 +23,6 @@
>>> >>  // RUN: echo "vptr_check:S" > %t.loc-supp
>>> >>  // RUN: UBSAN_OPTIONS="suppressions='%t.loc-supp':halt_on_error=1"
>>> not %run %t x- 2>&1 | FileCheck %s --check-prefix=CHECK-LOC-SUPPRESS
>>> >>
>>> >> -// FIXME: This test produces linker errors on Darwin.
>>> >> -// XFAIL: darwin
>>> >
>>> > Hi Alexey,
>>> >
>>> > Seems like this test still doesn't pass on Darwin, though for reasons
>>> > other than "linker errors";  see e.g.:
>>> >
>>> >
>>> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/3415/testReport/junit/UBSan-Standalone-x86_64/TestCases_TypeCheck/vptr_cpp/
>>> >
>>> > (and all following builds on that bot.)  Can you have a look?
>>> >
>>> > Thanks!
>>> > -Ahmed
>>> >
>>> >>  // REQUIRES: stable-runtime
>>> >>  #include <new>
>>> >>
>>> >>
>>> >>
>>> >> _______________________________________________
>>> >> llvm-commits mailing list
>>> >> llvm-commits at cs.uiuc.edu
>>> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
>>
>> --
>> Alexey Samsonov
>> vonosmas at gmail.com
>>
>
>
>
> --
> Alexey Samsonov
> vonosmas at gmail.com
>



-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150429/b2056bb6/attachment.html>