[PATCH] Sparc: support the "set" synthetic instruction.

Venkatraman Govindaraju venkatra at cs.wisc.edu
Tue Apr 28 19:43:12 PDT 2015


================
Comment at: lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:81
@@ +80,3 @@
+
+  void ExpandSET(MCInst &Inst, SMLoc IDLoc,
+                 SmallVectorImpl<MCInst> &Instructions,
----------------
Change the function name to expandSET().

According to the coding standard, function names should start with lower case.  

================
Comment at: lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:438
@@ +437,3 @@
+  // the imm operand can be either an expression or an immediate.
+  bool IsImm = Inst.getOperand(1).isImm();
+  uint64_t ImmValue = IsImm ? Inst.getOperand(1).getImm() : 0;
----------------
Use MCValOp itself.

http://reviews.llvm.org/D9089

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list