[llvm] r232142 - [MachineCopyPropagation] Fix a bug causing incorrect removal for the instruction sequences as follows

Quentin Colombet qcolombet at apple.com
Tue Apr 28 13:23:02 PDT 2015


Hi Ton,

LGTM.

Cheers,
-Quentin
> On Apr 28, 2015, at 1:03 PM, Tom Stellard <tom at stellard.net> wrote:
> 
> Tim, Evan
> 
> Ping for merging this patch to the 3.6 branch.
> 
> On Mon, Apr 20, 2015 at 08:27:52AM -0700, Tom Stellard wrote:
>> Hi Evan, Tim,
>> 
>> Is this patch OK for the 3.6 branch?
>> 
>> http://llvm.org/viewvc/llvm-project?view=revision&revision=232142
>> 
>> Thanks,
>> Tom
>> On Mon, Mar 23, 2015 at 09:19:59AM +0800, Hao Liu wrote:
>>> Hi Joerg,
>>> 
>>> It's a bug fix. I think it's better to merge to branch 3.6.
>>> 
>>> Thanks,
>>> -Hao
>>> 
>>> 2015-03-14 1:47 GMT+08:00 Joerg Sonnenberger <joerg at britannica.bec.de>:
>>>> Tom? Tim?
>>>> 
>>>> On Fri, Mar 13, 2015 at 04:34:14PM +0100, Arnaud A. de Grandmaison wrote:
>>>>> Yes, I think it is relevant for the 3.6 branch.
>>>>> 
>>>>> Cheers,
>>>>> Arnaud
>>>>> 
>>>>> -----Original Message-----
>>>>> From: llvm-commits-bounces at cs.uiuc.edu
>>>>> [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Joerg Sonnenberger
>>>>> Sent: 13 March 2015 16:14
>>>>> To: llvm-commits at cs.uiuc.edu
>>>>> Subject: Re: [llvm] r232142 - [MachineCopyPropagation] Fix a bug causing
>>>>> incorrect removal for the instruction sequences as follows
>>>>> 
>>>>> On Fri, Mar 13, 2015 at 05:15:23AM -0000, Hao Liu wrote:
>>>>>> Author: haoliu
>>>>>> Date: Fri Mar 13 00:15:23 2015
>>>>>> New Revision: 232142
>>>>>> 
>>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=232142&view=rev
>>>>>> Log:
>>>>>> [MachineCopyPropagation] Fix a bug causing incorrect removal for the
>>>>> instruction sequences as follows
>>>>>>   %Q5_Q6<def> = COPY %Q2_Q3
>>>>>>   %D5<def> =
>>>>>>   %D3<def> =
>>>>>>   %D3<def> = COPY %D6     // Incorrectly removed in
>>>>> MachineCopyPropagation
>>>>>>   Using of %D3 results in incorrect result ...
>>>>>> 
>>>>>>   Reviewed in http://reviews.llvm.org/D8242
>>>>> 
>>>>> Is this relevant for the 3.6 branch?
>>>>> 
>>>>> Joerg
>>>>> _______________________________________________
>>>>> llvm-commits mailing list
>>>>> llvm-commits at cs.uiuc.edu
>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list