[PATCH] Fix CombineToPostIndexedLoadStore in DAGCombiner.cpp

Tue Apr 28 04:47:54 PDT 2015

Hi Quentin,

   When running the ARM self tests I found 9 failing tests.

   I could fix 5 of them :
      2012-10-04-AAPCS-byval-align8.ll
      2012-10-18-PR14099-ByvalFrameAddress.ll
      2013-01-21-PR14992.ll
      byval_load_align.ll
      ldrd.ll

  There are 3 tests for which the code is worse, due to save/restore of registers modified by the automod. On our target, we added a target specific pass to fix these cases and fully benefit from the automod addressing mode. These tests are :
      truncstore-dag-combine.ll
      unaligned_load_store.ll
      wrong-t2stmia-size-opt.ll

  There is one test for which I suspect that the new code is wrong. A muls is generated in a sequence where it is checked that no muls is generated. The test is :
       avoid-cpsr-rmw.ll

  Also, what do you mean by "Attached the your patch for TOT, your test case needed to be updated as well" ? 

  Please tell me how you want me to proceed.

  Thanks,

   - François.

http://reviews.llvm.org/D9107

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/