[PATCH] Add sparc_le architecture (little-endian 32-bit Sparc).

Eric Christopher echristo at gmail.com
Mon Apr 27 11:18:42 PDT 2015


Few inline comments. Should be ok otherwise.

Thanks!

-eric


================
Comment at: lib/Target/Sparc/MCTargetDesc/SparcAsmBackend.cpp:224
@@ +223,3 @@
+    bool isLittleEndian() const {
+      StringRef name = TheTarget.getName();
+      return name == "sparcel";
----------------
No need for a temporary here?

================
Comment at: lib/Target/Sparc/SparcTargetMachine.cpp:63
@@ -59,3 +62,3 @@
                                        CodeGenOpt::Level OL, bool is64bit)
-    : LLVMTargetMachine(T, computeDataLayout(is64bit), TT, CPU, FS, Options, RM,
-                        CM, OL),
+    : LLVMTargetMachine(T,
+                        computeDataLayout(Triple(TT), is64bit),
----------------
clang-format?

================
Comment at: lib/Target/Sparc/SparcTargetMachine.cpp:135
@@ +134,3 @@
+
+SparcelTargetMachine::SparcelTargetMachine(const Target &T,
+					   StringRef TT,  StringRef CPU,
----------------
Ditto?

http://reviews.llvm.org/D8741

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list