[PATCH] [test-suite] Add test for basic correctness of frame lowering

Renato Golin renato.golin at linaro.org
Mon Apr 27 07:28:38 PDT 2015


================
Comment at: MultiSource/Makefile:5
@@ -4,3 +4,1 @@
 PARALLEL_DIRS  := Applications Benchmarks
-# For now only Mips uses UnitTests
-ifeq ($(ARCH),Mips)
----------------
kristof.beyls wrote:
> rengolin wrote:
> > This is a bit too generic. I'd add AArch64, maybe ARM, but not enable for everything before making sure all UnitTests work on all platforms we run the test-suite.
> The only unit test that this will enable to run extra is the frame_layout unit test that is being added by this patch.
> All the other pre-existing unit tests have been moved to a "Mips" directory inside the UnitTests sub-directory.
> This way, MultiSource/UnitTests becomes available for non-Mips-specific tests too.
> 
> My plan is to commit this patch as is. I expect to potentially see some bots fail on architectures that have e.g. not
> fully implemented dynamic stack realignment yet. I'll add skips for those architectures further down in the directory structure,
> to just skip the new frame_layout test case. I plan to do the commit of this test in the morning European time, when the commit rate is lower,
> to not disrupt others too much if it turns out some architectures do not pass the new frame_layout test.
Ok, sounds like a plan. Thanks!

http://reviews.llvm.org/D8922

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list