[PATCH] [mips] [IAS] Do not generate redundant ORi in createLShiftOri.

Daniel Sanders daniel.sanders at imgtec.com
Mon Apr 27 02:29:38 PDT 2015


LGTM with a tiny nit


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1644
@@ -1643,1 +1643,3 @@
   }
+  // There's no need for an ORi, if the immediate is 0.
+  if (Operand.isImm() && Operand.getImm() == 0)
----------------
Tiny nit: Remove the comma

http://reviews.llvm.org/D8969

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list