[PATCH] [zorg] llgo: add logfiles to build_libgo

[Andrew Wilkins]

Hi gkistanova, pcc,

llgo's "libgo" target builds libgo by executing
a Make subprocess; the Make build sends output
to log files on disk, and not to stdio. On the
llgo-builder slave, the libgo build step takes
more than the default timeout (1200s) to complete,
which is killed due to lack of output on stdio.

This diff adds the log files to the build step,
so the step doesn't time out and to assist in
diagnosing build failures. We also explicitly
specify the libgo and llgoi targets as steps.

http://reviews.llvm.org/D9283

Files:
  zorg/buildbot/builders/LLGoBuilder.py

Index: zorg/buildbot/builders/LLGoBuilder.py
===================================================================
--- zorg/buildbot/builders/LLGoBuilder.py
+++ zorg/buildbot/builders/LLGoBuilder.py
@@ -76,6 +76,25 @@
                            haltOnFailure=True,
                            description=["build llgo"],
                            workdir=llvm_objdir))
+    # Build libgo
+    f.addStep(NinjaCommand(name="build_libgo",
+                           targets=["libgo"],
+                           haltOnFailure=True,
+                           logfiles={
+                               'libgo-build-out': 'tools/llgo/libgo-prefix/src/libgo-stamp/libgo-build-out.log',
+                               'libgo-build-err': 'tools/llgo/libgo-prefix/src/libgo-stamp/libgo-build-err.log',
+                               'libgo-configure-out': 'tools/llgo/libgo-prefix/src/libgo-stamp/libgo-configure-out.log',
+                               'libgo-configure-err': 'tools/llgo/libgo-prefix/src/libgo-stamp/libgo-configure-err.log',
+                           },
+                           lazylogfiles=True,
+                           description=["build libgo"],
+                           workdir=llvm_objdir))
+    # Build llgoi
+    f.addStep(NinjaCommand(name="build_llgoi",
+                           targets=["llgoi"],
+                           haltOnFailure=True,
+                           description=["build llgoi"],
+                           workdir=llvm_objdir))
     # Test llgo
     f.addStep(NinjaCommand(name="test_llgo",
                            targets=["check-llgo"],

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9283.24444.patch
Type: text/x-patch
Size: 1612 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150426/53278721/attachment.bin>