[llvm] r235788 - Assert that Process::FindInEnvPath() is passed a relative path.

Nico Weber nicolasweber at gmx.de
Fri Apr 24 15:18:46 PDT 2015


Author: nico
Date: Fri Apr 24 17:18:46 2015
New Revision: 235788

URL: http://llvm.org/viewvc/llvm-project?rev=235788&view=rev
Log:
Assert that Process::FindInEnvPath() is passed a relative path.

It misbehaves with absolute paths. (So does path::append().)
Goes with clang r235787.

Modified:
    llvm/trunk/lib/Support/Process.cpp

Modified: llvm/trunk/lib/Support/Process.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Process.cpp?rev=235788&r1=235787&r2=235788&view=diff
==============================================================================
--- llvm/trunk/lib/Support/Process.cpp (original)
+++ llvm/trunk/lib/Support/Process.cpp Fri Apr 24 17:18:46 2015
@@ -29,6 +29,7 @@ using namespace sys;
 Optional<std::string> Process::FindInEnvPath(const std::string& EnvName,
                                              const std::string& FileName)
 {
+  assert(!path::is_absolute(FileName));
   Optional<std::string> FoundPath;
   Optional<std::string> OptPath = Process::GetEnv(EnvName);
   if (!OptPath.hasValue())





More information about the llvm-commits mailing list