[PATCH] TableGen: AsmMatcherEmitter: Don't use custom converters for instruction aliases
ahmed.bougacha at gmail.com
Fri Apr 24 13:25:11 PDT 2015
I can see this being useful, but I don't know these parts very well, so, just to make sure I understand this correctly: someone might need to have an InstAlias-specific AsmMatchConverter, someday, right? And they could restore the current behavior - which I can see being useful as well - by setting that to the same converter as the aliasee? Also, when you say the "converter supplied with the alias", that would be the tblgen-erated converter, right?
If that makes no sense, I'm not qualified to review; if it does, LGTM ;)
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:441
@@ -440,1 +440,3 @@
+ /// If this matchable was generated from and InstAlias.
+ bool IsInstAlias;
and -> an
More information about the llvm-commits