[lld] r235357 - [GNU/ELF] Add support for -X/--discard-locals.

[Aaron Ballman]

On Fri, Apr 24, 2015 at 12:30 PM, Davide Italiano <davide at freebsd.org> wrote:
>>> On Apr 24, 2015 7:40 AM, "Aaron Ballman" <aaron at aaronballman.com> wrote:
>>>>
>>>> This commit is still causing failures on Windows. Can you please fix or
>>>> revert?
>>>>
>
> I don't have a Windows machine and I'm not able to reproduce neither
> on Linux or FreeBSD, but I think I identified  the problem.
> I would appreciate if you could tell tell me if this fixes your issue
> before I commit it.
>
> davide at rabbit1:/exps/llvm/tools/lld/test/elf % svn diff
> Index: discard-locals.test
> ===================================================================
> --- discard-locals.test (revision 235613)
> +++ discard-locals.test (working copy)
> @@ -1,7 +1,7 @@
>  # Test that -X/--discard-locals works.
>  #
>  #RUN: yaml2obj -format=elf %s -o=%t.o
> -#RUN: lld -flavor gnu %t.o -shared -X -o %t1
> +#RUN: lld -flavor -target x86_64 gnu %t.o -shared -X -o %t1

Fixing up the run line to be -flavor gnu -target x86_64 does pass for
me on Windows.

Thanks!

~Aaron

>  #RUN: llvm-objdump -t %t1 | FileCheck %s
>
>  #CHECK-NOT: 0000000000400121 l .rodata 00000000 .Lsym8
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare