[patch] Delete unnecessary generality in loadFile

Rui Ueyama ruiu at google.com
Thu Apr 23 13:12:07 PDT 2015

This is a change I wanted to create, so LGTM. Thank you for doing this.

One thing this could be improved is probably to return
ErrorOr<unique_ptr<File>> instead of error_code. Returning the actual
return value using 3rd argument which is passed-by-reference looks a bit

On Thu, Apr 23, 2015 at 1:06 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> loadFile can load mulitple files just because yaml has a feature for
> putting multiple documents in one file.
> Designing a linker around what yaml can do seems like a bad idea to
> me. The attached wip patch changes it to read a single file. It also
> updates one test to show the difference.
> OK with the remaining tests updated?
> Cheers,
> Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150423/ed9004db/attachment.html>

More information about the llvm-commits mailing list