[PATCH] [asan] Print SHADOW_SCALE and SHADOW_GRANULARITY as decimal values.

Alexey Samsonov vonosmas at gmail.com
Thu Apr 23 11:56:07 PDT 2015


I think this patch is definitely a positive change.


================
Comment at: test/asan/TestCases/debug_mapping.cc:15
@@ -14,3 +14,3 @@
   size_t scale, offset;
   __asan_get_shadow_mapping(&scale, &offset);
 
----------------
timurrrr wrote:
> I wonder if the interface function's first parameter type should be changed to `int*`.
I agree that int* would make more sense, but rather not change it now (it's declared in a public header after all). size_t also works, after all.

http://reviews.llvm.org/D9224

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list