[PATCH] Add a shrink-wrapping pass to improve the placement of prologue and epilogue.

Quentin Colombet qcolombet at apple.com
Thu Apr 23 09:54:54 PDT 2015


Hi Krzysztof,

> On Apr 23, 2015, at 6:29 AM, Krzysztof Parzyszek <kparzysz at codeaurora.org> wrote:
> 
> I have a patch that does this for Hexagon.  It's implemented as a part of PEI, specifically in HexagonFrameLowering::insertPrologue.

How does the generic pass perform for you?

I would be curious to see how we can improve it.

> 
> The problem with multiple prologs is that this can increase code size, plus it's a lot harder to identify the set of registers that need to be saved in each prolog.  You don't want to be saving more registers than you need.

Indeed, and at least for now, I haven’t found cases where this is really useful. Therefore the current pass just look for one prologue and one epilogue.

Cheers,
-Quentin

> 
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D9210
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 





More information about the llvm-commits mailing list