[PATCH] [asan] debug_mapping.cc should also pass when the leading digit is hexadecimal.

[Timur Iskhodzhanov]

Thanks for working on this!

чт, 23 апр. 2015 г. в 16:54, Daniel Sanders <Daniel.Sanders at imgtec.com>:

> > -----Original Message-----
> > From: Timur Iskhodzhanov [mailto:timurrrr at google.com]
> > Sent: 23 April 2015 14:38
> > To: Daniel Sanders; kcc at google.com; Sagar Thakur; timurrrr at google.com
> > Cc: llvm-commits at cs.uiuc.edu
> > Subject: Re: [PATCH] [asan] debug_mapping.cc should also pass when the
> > leading digit is hexadecimal.
> >
> > Nice catch, I've overlooked that code!
> >
> > `SHADOW_SCALE` is currently a constant equal to `3` and it can't be more
> > than 8 with the current ASan design, I think?
>
> Now that you mention it, I see there's a 'CHECK(SHADOW_SCALE >= 3 &&
> SHADOW_SCALE <= 7);' a few lines down.
>
> > Probably, the same applies to `SHADOW_GRANULARITY` - it is currently
> equal
> > to 8, can't be more than 256 and I'd argue we should always print them
> out as
> > decimals for readability.
> >
> > That's being said, I think the `Printf` line you're referring to should
> be
> > changed to just use `%d`.
> > [I suspect this is a side effect of copy-pasting code]
>
> That makes sense to me. I'll upload a patch for those two shortly.
>
> > http://reviews.llvm.org/D9199
> >
> > EMAIL PREFERENCES
> >   http://reviews.llvm.org/settings/panel/emailpreferences/
> >
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150423/1cb6f62a/attachment.html>