[PATCH] [asan] debug_mapping.cc should also pass when the leading digit is hexadecimal.

Daniel Sanders Daniel.Sanders at imgtec.com
Thu Apr 23 06:24:36 PDT 2015


I don't mind only changing the SHADOW_OFFSET expression since that fixes my test failure but I have to ask:
Does it really make sense to 'Printf("SHADOW_SCALE: %zx\n", (uptr)SHADOW_SCALE)' in asan_rtl.cc and expect the output to be decimal in the debug_mapping.cc test?

> -----Original Message-----
> From: Timur Iskhodzhanov [mailto:timurrrr at google.com]
> Sent: 23 April 2015 13:44
> To: Daniel Sanders; kcc at google.com; Sagar Thakur; timurrrr at google.com
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] [asan] debug_mapping.cc should also pass when the
> leading digit is hexadecimal.
> 
> `SHADOW_OFFSET` expression change -- LGTM
> 
> 
> ================
> Comment at: test/asan/TestCases/debug_mapping.cc:10
> @@ -9,3 +9,3 @@
>  // printed because of verbosity=1
> -// CHECK: SHADOW_SCALE: [[SCALE:[0-9]+]]
> -// CHECK: SHADOW_OFFSET: [[OFFSET:[0-9]+]]
> +// CHECK: SHADOW_SCALE: [[SCALE:[0-9a-f]+]]
> +// CHECK: SHADOW_OFFSET: [[OFFSET:[0-9a-f]+]]
> ----------------
> Please leave the SCALE regexp unchanged
> 
> http://reviews.llvm.org/D9199
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> 





More information about the llvm-commits mailing list