[PATCH][LNT] Allow samples to be ordered "bigger is better"

Chris Matthews chris.matthews at apple.com
Wed Apr 22 17:11:27 PDT 2015


Patch #1 LGTM.  Please also update the test cases in tests/server/db, and perhaps add an instance of a sample type to one of the example DBs so that it gets worked out when the tests are run.

Patch #2 also LGTM.  I like the idea of a score type, it would be useful in a lot of situations.

> On Apr 17, 2015, at 6:47 AM, James Molloy <james at jamesmolloy.co.uk> wrote:
> 
> Hi Chris,
> 
> Two patches are attached. The first introduces the concept of a "bigger is better" sample type. This is useful for benchmarks that emit metrics such as iterations/sec, or some abstract "score". The patch adds a database migration and does the appropriate plumbing.
> 
> The second patch is a bit more hacky, but it adds a "score" sample type to the default schema so any user can insert at least some samples with "bigger is better" ordering.
> 
> If you'd prefer not to have this sample type upstream because it hasn't got any use in the official instance, I'm happy to keep this as a downstream patch.
> 
> Cheers,
> 
> James
> <0001-LNT-Add-the-ability-for-test-samples-to-be-interpret.patch><0002-LNT-Add-a-score-sample-type.patch>





More information about the llvm-commits mailing list