[PATCH] [asan] debug_mapping.cc should also pass when the leading digit is hexadecimal.

Timur Iskhodzhanov timurrrr at google.com
Wed Apr 22 10:09:07 PDT 2015


Can you please provide an example output that doesn't match this?

ср, 22 апр. 2015, 19:23, Daniel Sanders <daniel.sanders at imgtec.com>:

> Hi kcc, timurrrr, sagar,
>
> Previously the CHECK directives only matched decimal digits causing it to
> match
> '7' on x86_64 instead of the whole value.
>
> This fixes a failure on mips-linux-gnu targets where the leading digit is
> 'a'.
>
> http://reviews.llvm.org/D9199
>
> Files:
>   test/asan/TestCases/debug_mapping.cc
>
> Index: test/asan/TestCases/debug_mapping.cc
> ===================================================================
> --- test/asan/TestCases/debug_mapping.cc
> +++ test/asan/TestCases/debug_mapping.cc
> @@ -7,8 +7,8 @@
>  #include <stdlib.h>
>
>  // printed because of verbosity=1
> -// CHECK: SHADOW_SCALE: [[SCALE:[0-9]+]]
> -// CHECK: SHADOW_OFFSET: [[OFFSET:[0-9]+]]
> +// CHECK: SHADOW_SCALE: [[SCALE:[0-9a-f]+]]
> +// CHECK: SHADOW_OFFSET: [[OFFSET:[0-9a-f]+]]
>
>  int main() {
>    size_t scale, offset;
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150422/bbc6693d/attachment.html>


More information about the llvm-commits mailing list