[PATCH] [LoopInterchange] Add support to interchange loops with reductions.

Renato Golin renato.golin at linaro.org
Wed Apr 22 09:53:18 PDT 2015

Hi Karthik,

Looks good to me with the two nitpicks. Feel free to commit with those changes.


Comment at: test/Transforms/LoopInterchange/reductions.ll:49
@@ +48,3 @@
+; CHECK:    br label %for.body3.lr.ph.preheader
+; CHECK:    %add = add nsw i32 %X.promoted, %0
nitpick: you don't need to match %0 here. It won't match if some pass adds a new unrelated operation. Just match up to promoted.

Comment at: test/Transforms/LoopInterchange/reductions.ll:113
@@ +112,3 @@
+; CHECK:    br label %for.cond4.preheader.preheader.preheader
+; CHECK:    %add13 = add nsw i32 %Y.promoted, %1
Same here. Mainly because %1 and %0 were not part of the rest of the match.



More information about the llvm-commits mailing list