[PATCH] Fix CombineToPostIndexedLoadStore in DAGCombiner.cpp
    Quentin Colombet 
    qcolombet at apple.com
       
    Wed Apr 22 09:37:54 PDT 2015
    
    
  
Hi François,
LGTM with a pair of nitpicks.
Please commit with those fixes or let me know if you want I commit for you.
Nice catch BTW.
Thanks,
-Quentin
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9079
@@ +9078,3 @@
+      // Look for a real use, i.e. one use that is not a load / store op, or one
+      // that cannot be folded as addressing mode
+      bool TryNext = true;
----------------
Period at the end of the comment.
================
Comment at: test/CodeGen/ARM/automod-test.ll:33
@@ +32,3 @@
+; Function Attrs: nounwind
+define void @compute(i32* nocapture readonly %IDX) #0 {
+entry:
----------------
Add a CHECK-LABEL line.
http://reviews.llvm.org/D9107
EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
    
    
More information about the llvm-commits
mailing list