[PATCH] Fix correctness check for test_vec_fpextend_double

Pirama Arumuga Nainar pirama at google.com
Tue Apr 21 15:59:29 PDT 2015


Hi dsanders, srhines,

Remove the CHECK-DAG calls introduced in r235341, and add a comment that
this test may break due to scheduling variations.

This patch completes the fix discussed in http://reviews.llvm.org/D8804

http://reviews.llvm.org/D9178

Files:
  test/CodeGen/Mips/fp16-promote.ll

Index: test/CodeGen/Mips/fp16-promote.ll
===================================================================
--- test/CodeGen/Mips/fp16-promote.ll
+++ test/CodeGen/Mips/fp16-promote.ll
@@ -57,14 +57,16 @@
   ret <4 x float> %b
 }
 
+; This test is not robust against variations in instruction scheduling.
+; See the discussion in http://reviews.llvm.org/D8804
 ; CHECK-LIBCALL-LABEL: test_vec_fpext_double:
-; CHECK-LIBCALL-DAG: %call16(__gnu_h2f_ieee)
-; CHECK-LIBCALL-DAG: %call16(__gnu_h2f_ieee)
-; CHECK-LIBCALL-DAG: %call16(__gnu_h2f_ieee)
-; CHECK-LIBCALL-DAG: %call16(__gnu_h2f_ieee)
-; CHECK-LIBCALL-DAG: cvt.d.s
-; CHECK-LIBCALL-DAG: cvt.d.s
-; CHECK-LIBCALL-DAG: cvt.d.s
+; CHECK-LIBCALL: %call16(__gnu_h2f_ieee)
+; CHECK-LIBCALL: %call16(__gnu_h2f_ieee)
+; CHECK-LIBCALL: %call16(__gnu_h2f_ieee)
+; CHECK-LIBCALL: cvt.d.s
+; CHECK-LIBCALL: cvt.d.s
+; CHECK-LIBCALL: cvt.d.s
+; CHECK-LIBCALL: %call16(__gnu_h2f_ieee)
 ; CHECK-LIBCALL: cvt.d.s
 define <4 x double> @test_vec_fpext_double(<4 x half>* %p) #0 {
   %a = load <4 x half>, <4 x half>* %p, align 8

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9178.24183.patch
Type: text/x-patch
Size: 1067 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150421/37ba5c4b/attachment.bin>


More information about the llvm-commits mailing list