[PATCH] [zorg] LitTestCommand aborts if Verbose log line is not preceded by a valid test status line.

Galina gkistanova at gmail.com
Tue Apr 21 14:36:39 PDT 2015


Assuming you will fix the cosmetic issue I have commented in-line.


REPOSITORY
  rL LLVM

================
Comment at: zorg/buildbot/commands/LitTestCommand.py:60
@@ +59,3 @@
+              "error: missing test status line, skipping log")
+    else:
+        code, name = self.lastTestResult
----------------
Maybe handle it the other way around?
Handling the normal case first and the error case at the end. Something like:

  if self.lastTestResult:
     # We have finished getting information for one test, handle it.
     code, name = self.lastTestResult
     ...
  else:
     # We could get a malformed test status line.
     # Report an issue for verbose mode and skip it.
     if self.lastTestResult is None:
     ...

  # Reset the current state.
  self.lastTestResult = None
  self.activeVerboseLog = None

http://reviews.llvm.org/D9091

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list