[PATCH] [SeparateConstOffsetFromGEP] garbage-collect intermediate instructions

Mark Heffernan meheff at google.com
Tue Apr 21 12:40:30 PDT 2015


LGTM with the addition of the new flag to the unit tests.


================
Comment at: test/Transforms/SeparateConstOffsetFromGEP/NVPTX/split-gep-and-gvn.ll:2
@@ -1,3 +1,3 @@
 ; RUN: llc < %s -march=nvptx64 -mcpu=sm_20 | FileCheck %s --check-prefix=PTX
-; RUN: opt < %s -S -separate-const-offset-from-gep -gvn -dce | FileCheck %s --check-prefix=IR
+; RUN: opt < %s -S -separate-const-offset-from-gep -gvn | FileCheck %s --check-prefix=IR
 
----------------
Did you mean to add your new dead code checking flag here?

================
Comment at: test/Transforms/SeparateConstOffsetFromGEP/NVPTX/split-gep.ll:1
@@ -1,2 +1,2 @@
-; RUN: opt < %s -separate-const-offset-from-gep -dce -S | FileCheck %s
+; RUN: opt < %s -separate-const-offset-from-gep -S | FileCheck %s
 
----------------
And here?

http://reviews.llvm.org/D9096

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list