[PATCH] Support arm32 R_ARM_V4BX relocation format

Rui Ueyama ruiu at google.com
Tue Apr 21 11:23:28 PDT 2015


LGTM


================
Comment at: tools/yaml2obj/yaml2elf.cpp:362
@@ +361,3 @@
+    // Some special relocation, R_ARM_v4BX for instance, does not have
+    // an external reference.
+    SymN2I.lookup(Rel.Symbol, SymIdx);
----------------
Maybe you want to also add "... So we ignore the return value of lookup() here."

http://reviews.llvm.org/D9162

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list