[PATCH] Fix CombineToPostIndexedLoadStore in DAGCombiner.cpp

Francois de Ferriere francois.de-ferriere at st.com
Tue Apr 21 05:24:51 PDT 2015


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8853
@@ -8852,4 +8852,3 @@
   for (SDNode *Op : Ptr.getNode()->uses()) {
-    if (Op == N ||
-        (Op->getOpcode() != ISD::ADD && Op->getOpcode() != ISD::SUB))
+    if (Op->getOpcode() != ISD::ADD && Op->getOpcode() != ISD::SUB)
       continue;
----------------
qcolombet wrote:
> I don’t get why this change is useful.
Since N is a Load/Store operation, the check is redundant with the ADD/SUB check. This change was just to simplify the code, I will remove it.

http://reviews.llvm.org/D9107

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list