[PATCH] [x86] allow 64-bit extracted vector element integer stores on a 32-bit system

Sanjay Patel spatel at rotateright.com
Mon Apr 20 18:15:55 PDT 2015

Comment at: lib/Target/X86/X86ISelLowering.cpp:22941-22942
@@ +22940,4 @@
+    SDValue NewExtract = DAG.getNode(ISD::EXTRACT_VECTOR_ELT, dl, MVT::f64,
+                                     DAG.getNode(ISD::BITCAST, dl, MVT::v2f64,
+                                                 OldExtract.getOperand(0)),
+                                     OldExtract.getOperand(1));
ab wrote:
> Isn't v2f64 too specific?  What if you have a 256bit vector?  (I haven't seen any related check in the function)
Yes, you're absolutely right. This won't work as-is for an AVX-capable target in 32-bit mode. Nice catch!



More information about the llvm-commits mailing list