[PATCH] Teach InlineCost to account for a null check which can be folded away

Sanjoy Das sanjoy at playingwithpointers.com
Mon Apr 20 16:24:02 PDT 2015


Minor comment inline.  Other than that I don't see any issues with this change, but I also don't know this area of code well enough to LGTM this.


================
Comment at: lib/Analysis/IPA/InlineCost.cpp:568
@@ +567,3 @@
+    // argument?
+    if (isa<Argument>(LHS)) {
+      unsigned ArgNo = 0;
----------------
There is an `Argument::getArgNo`.

http://reviews.llvm.org/D9129

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list