[PATCH] Rename determineInsertionPoints to determinePHINodes, expose it so it can be reused

Quentin Colombet qcolombet at apple.com
Mon Apr 20 14:29:03 PDT 2015


Hi Daniel


================
Comment at: include/llvm/Transforms/Utils/PromoteMemToReg.h:70
@@ +69,3 @@
+                       const DenseMap<DomTreeNode *, unsigned> &DomLevels,
+                       SmallVectorImpl<std::pair<unsigned, BasicBlock *>> &PHIBlocks);
+
----------------
>From the user stand point I think we should not have to provide the DomLevels and the LiveInBlocks.

The BBNumbers are already on your “to-remove” list, so it is fine for now.

http://reviews.llvm.org/D9118

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list