[PATCH] Move MachineValueType.h from CodeGen to MC

Pete Cooper peter_cooper at apple.com
Mon Apr 20 13:37:22 PDT 2015


Hi all

This patch moves MachineValueType.h from CodeGen to MC.  There are a few places in X86 MC level tools (assembly instrumentation, inst comments, shuffle decode) which include this file but shouldn’t due to layering violations.

Given that I believe the M in MC stands for ‘Machine’, it makes sense to me that MachineValueType lives there too.  Its also a completely self contained header, so is relatively painless to move.

I’ve updated all places which include this file and sorted the includes appropriately.  Let me know if there’s anything else to be done.

I’ll send out a message to the list to make it clear to out of tree target owners that this could impact them, although its an easy thing to update if they have issues.

Note, i also considered actually renaming it to MCValueType.h to match other MC headers, but ConstantPool.h already broke that convention.  I’m happy to do that in this commit or in a later one if anyone is strongly for the idea.

Also, if this is approved i’ll do a separate commit to stop X86 MC tools from linking against X86 CodeGen.

Cheers,
Pete



More information about the llvm-commits mailing list