[PATCH] Fix flakiness in fp16-promote.ll

Pirama Arumuga Nainar pirama at google.com
Mon Apr 20 10:28:16 PDT 2015


Hi mzolotukhin, srhines, ab,

In the f16-promote test, make the checks for native conversion instructions
similar to the libcall checks:
- Remove hard coded register names
- Do not check exact instruction sequences.

This fixes test flakiness due to non-determinism in instruction
scheduling and register allocation.  I also fixed a few minor things in
the CHECK-LIBCALL checks.

I'll try to find a way to check that unnecessary loads, stores, or
conversions don't happen.

http://reviews.llvm.org/D9112

Files:
  test/CodeGen/ARM/fp16-promote.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9112.24028.patch
Type: text/x-patch
Size: 35063 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150420/f6766030/attachment.bin>


More information about the llvm-commits mailing list