3.6.1 patch nomination: r231984 & r232176 (illegal type support fixes)

Owen Anderson resistor at mac.com
Mon Apr 20 09:58:02 PDT 2015


> On Apr 20, 2015, at 8:30 AM, Tom Stellard <tom at stellard.net> wrote:
> 
> On Wed, Mar 18, 2015 at 12:56:59PM +0000, Paweł Bylica wrote:
>> --------------------------------------------------------------------
>> r231984:
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=231984&view=rev
>> Log:
>> Handle big index in getelementptr instruction
>> 
>> CodeGen incorrectly ignores (assert from APInt) constant index bigger
>> than 2^64 in getelementptr instruction. This is a test and fix for that.
>> 
>> Patch by Paweł Bylica!
>> 
>> Reviewed By: rnk
>> 
>> Subscribers: majnemer, rnk, mcrosier, resistor, llvm-commits
>> 
>> Differential Revision: http://reviews.llvm.org/D8219
>> 
>> Added:
>>    llvm/trunk/test/CodeGen/X86/getelementptr.ll
>> Modified:
>>    llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp
>>    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
>> 
> 
> Hi Owen,
> 
> Is this patch OK for the 3.6 branch?

I approve it.

—Owen



More information about the llvm-commits mailing list