[llvm] r235267 - Remove the CFIEnforcing flag from TargetOptions as it is unused.

Eric Christopher echristo at gmail.com
Sat Apr 18 20:20:59 PDT 2015


Author: echristo
Date: Sat Apr 18 22:20:59 2015
New Revision: 235267

URL: http://llvm.org/viewvc/llvm-project?rev=235267&view=rev
Log:
Remove the CFIEnforcing flag from TargetOptions as it is unused.

Modified:
    llvm/trunk/include/llvm/CodeGen/CommandFlags.h
    llvm/trunk/include/llvm/Target/TargetOptions.h
    llvm/trunk/lib/CodeGen/TargetOptionsImpl.cpp

Modified: llvm/trunk/include/llvm/CodeGen/CommandFlags.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/CommandFlags.h?rev=235267&r1=235266&r2=235267&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/CommandFlags.h (original)
+++ llvm/trunk/include/llvm/CodeGen/CommandFlags.h Sat Apr 18 22:20:59 2015
@@ -231,11 +231,6 @@ FCFI("fcfi",
      cl::desc("Apply forward-edge control-flow integrity"),
      cl::init(false));
 
-cl::opt<bool>
-CFIEnforcing("cfi-enforcing",
-             cl::desc("Enforce CFI or pass the violation to a function."),
-             cl::init(false));
-
 // Note that this option is linked to the cfi-enforcing option above: if
 // cfi-enforcing is set, then the cfi-func-name option is entirely ignored. If
 // cfi-enforcing is false and no cfi-func-name is set, then a default function
@@ -280,8 +275,6 @@ static inline TargetOptions InitTargetOp
   Options.MCOptions = InitMCTargetOptionsFromFlags();
   Options.JTType = JTableType;
   Options.FCFI = FCFI;
-  Options.CFIEnforcing = CFIEnforcing;
-  Options.CFIFuncName = CFIFuncName;
 
   Options.ThreadModel = TMModel;
 

Modified: llvm/trunk/include/llvm/Target/TargetOptions.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetOptions.h?rev=235267&r1=235266&r2=235267&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Target/TargetOptions.h (original)
+++ llvm/trunk/include/llvm/Target/TargetOptions.h Sat Apr 18 22:20:59 2015
@@ -74,7 +74,7 @@ namespace llvm {
           TrapFuncName(), FloatABIType(FloatABI::Default),
           AllowFPOpFusion(FPOpFusion::Standard), JTType(JumpTable::Single),
           FCFI(false), ThreadModel(ThreadModel::POSIX),
-          CFIEnforcing(false), CFIFuncName() {}
+          CFIFuncName() {}
 
     /// PrintMachineCode - This flag is enabled when the -print-machineinstrs
     /// option is specified on the command line, and should enable debugging
@@ -230,10 +230,6 @@ namespace llvm {
     /// for things like atomics
     ThreadModel::Model ThreadModel;
 
-    /// CFIEnforcing - This flags controls whether or not CFI violations cause
-    /// the program to halt.
-    bool CFIEnforcing;
-
     /// getCFIFuncName - If this returns a non-empty string, then this is the
     /// name of the function that will be called for each CFI violation in
     /// non-enforcing mode.
@@ -270,7 +266,6 @@ inline bool operator==(const TargetOptio
     ARE_EQUAL(JTType) &&
     ARE_EQUAL(FCFI) &&
     ARE_EQUAL(ThreadModel) &&
-    ARE_EQUAL(CFIEnforcing) &&
     ARE_EQUAL(CFIFuncName) &&
     ARE_EQUAL(MCOptions);
 #undef ARE_EQUAL

Modified: llvm/trunk/lib/CodeGen/TargetOptionsImpl.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TargetOptionsImpl.cpp?rev=235267&r1=235266&r2=235267&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/TargetOptionsImpl.cpp (original)
+++ llvm/trunk/lib/CodeGen/TargetOptionsImpl.cpp Sat Apr 18 22:20:59 2015
@@ -53,8 +53,7 @@ StringRef TargetOptions::getTrapFunction
 }
 
 /// getCFIFuncName - If this returns a non-empty string, then it is the name of
-/// the function that gets called on CFI violations in CFI non-enforcing mode
-/// (!TargetOptions::CFIEnforcing).
+/// the function that gets called on CFI violations in CFI non-enforcing mode.
 StringRef TargetOptions::getCFIFuncName() const {
   return CFIFuncName;
 }





More information about the llvm-commits mailing list