[PATCH] [mips] [IAS] Add support for the .module softfloat/hardfloat directives.

Matthew Fortune matthew.fortune at imgtec.com
Fri Apr 17 06:05:16 PDT 2015


================
Comment at: lib/Target/Mips/MipsTargetStreamer.h:104
@@ +103,3 @@
+  virtual void emitDirectiveModuleHardFloat() {
+    ABIFlagsSection.setFpABI(MipsABIFlagsSection::FpABIKind::ANY,
+                             ABIFlagsSection.Is32BitABI);
----------------
This looks fishy, the FPABI should return to whatever hard-float ABI is in force due to other options. I.e. you need to know which fp=32|xx|64 was set and/or if oddspreg is in force and/or if single float is in force.

'Any' is generally used to describe a no-float ABI which is very different from hard-float.

http://reviews.llvm.org/D9073

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list