[compiler-rt] r233215 - On OS X, explicitly use libc++

[Nico Weber]

On Thu, Apr 16, 2015 at 8:34 AM, Kuba Brecka <kuba.brecka at gmail.com> wrote:

> > ASan requiring 10.7 is fine for us.
> >
> > The problem is that we're only doing a single build of Clang and
> > compiler-rt, and we use that for both non-asan and asan builds of
> > Chrome. If I build compiler-rt with MACOSX_DEPLOYMENT_TARGET=10.7, are
> > you saying that the non-asan parts of compiler-rt will still work on
> > 10.6 machines? Because that's all I need.
> >
> > Apologies for the confusion here. I don't really know much about
> > compiler-rt or Mac.
>
> I think you should be fine with what you suggested before, i.e. not
> setting MACOSX_DEPLOYMENT_TARGET at all.  ASan will get built with support
> for 10.7+ no matter what your OS version is.  The non-sanitizer parts
> (builtins) only build into a .a archive, so the deployment target doesn’t
> (shouldn’t) matter here.
>

clang looks at that env var and might use it for things other than setting
the min OS version in the mach-o output file. Look e.g. for
isMacosxVersionLT() in clang's lib, this affects abi things like ObjC
calling conventions and whatnot. We do need to set this while
compiling…anything.

(resending from @chromium, sorry about the dupe mail)


> Kuba
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150416/69db9802/attachment.html>