[llvm] r235026 - Add range iterators for post order and inverse post order. Use them

Daniel Berlin dberlin at dberlin.org
Wed Apr 15 12:16:18 PDT 2015


On Wed, Apr 15, 2015 at 11:00 AM, David Blaikie <dblaikie at gmail.com> wrote:
>));
>
>
> You can probably use "make_range" here (& elsewhere in this patch)

Oh, i copied what we did elsewhere (see depth_first in DepthFirstIterator.h)

I'll change it to make_range.

>
> & did you mean to pass 'G' by value? (I would've expected const ref, I
> guess, but not sure what sort of thing it is - oh, I see, it's a pointer?
> Perhaps "T *G" to enforce that if that's reasonable?)

Yeah, this is a case where i copied what the iterators already took,
assuming it was reasonable.
I expect this should be identical to depth_first (which is const T &
G) to be honest.
I'll update it.



More information about the llvm-commits mailing list