[PATCH] Implement MUL, MUH, MULU and MUHU instructions

[Daniel Sanders]

LGTM except for a small issue in the muhu and possibly muh instructions. Once muhu is corrected and muh has been confirmed correct you can commit.


================
Comment at: lib/Target/Mips/MicroMips32r6InstrInfo.td:25
@@ +24,3 @@
+class MUL_MMR6_ENC : ARITH_FM_MMR6<"mul", 0x18>;
+class MUH_MMR6_ENC : ARITH_FM_MMR6<"muh", 0x2c>;
+class MULU_MMR6_ENC : ARITH_FM_MMR6<"mulu", 0x98>;
----------------
I believe this is correct, but the encoding diagram only has 9-bits specified for this 10-bit field. Presumably is a leading zero is missing. I've asked the relevant people to confirm and correct the documentation.

================
Comment at: lib/Target/Mips/MicroMips32r6InstrInfo.td:27
@@ -24,1 +26,3 @@
+class MULU_MMR6_ENC : ARITH_FM_MMR6<"mulu", 0x98>;
+class MUHU_MMR6_ENC : ARITH_FM_MMR6<"muhu", 0xe8>;
 
----------------
I make it 0xd8.

http://reviews.llvm.org/D8894

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/