[PATCH] [PPC64] Add v1i128 Vector Type

Kit Barton kbarton at ca.ibm.com
Tue Apr 14 07:53:20 PDT 2015


================
Comment at: include/llvm/IR/Constants.h:676
@@ -675,2 +675,3 @@
   static Constant *get(LLVMContext &Context, ArrayRef<uint64_t> Elts);
+  static Constant *get(LLVMContext &Context, ArrayRef<__uint128_t> Elts);
   static Constant *get(LLVMContext &Context, ArrayRef<float> Elts);
----------------
hfinkel wrote:
> We have don't have a standard __uint128_t type, so you can't use it.
> 
> Also, you don't define these anywhere. Do you need them?
> 
This is one of the changes that I had questions about.
I found this while I was looking through svn history of other patches that had added types to LLVM. I haven't tried to add any tests that contain 128bit constants, but I would expect these methods to be used in that scenario (that's purely speculation on my part). 

I'm OK with not modifying this, since it is not needed right now to compile/run. I added it originally for completeness.

http://reviews.llvm.org/D8564

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list