[PATCH] [Inliner] Use whitelist instead of blacklist when checking function attribute compatibility and make the check stricter

Michael Kuperstein michael.m.kuperstein at intel.com
Tue Apr 14 02:41:41 PDT 2015


As a side note, I just ran into the - more or less - mirror image of this.

CodeExtractor currently doesn't copy any function attributes into the function it creates (except, for some reason, nounwind). 
Copying all attributes, however, doesn't seem safe. For example, a readnone function can have a stack allocation and the pointer can be passed into the extracted function. On the other hand, we definitely want to copy target-cpu/target-features.


http://reviews.llvm.org/D7802

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list