[lld] r234736 - Speculative build fix for lld on Windows

Simon Atanasyan simon at atanasyan.com
Mon Apr 13 04:30:29 PDT 2015


On Mon, Apr 13, 2015 at 2:00 PM, Hans Wennborg <hans at hanshq.net> wrote:
> Author: hans
> Date: Mon Apr 13 06:00:22 2015
> New Revision: 234736
>
> URL: http://llvm.org/viewvc/llvm-project?rev=234736&view=rev
> Log:
> Speculative build fix for lld on Windows
>
> I can't access my Windows machine at the moment, but the build was breaking with:
>
> c:\b\build\slave\crwinclanglld\build\src\third_party\llvm\tools\lld\lib\readerwriter\elf\mips\MipsTargetLayout.h(38) : error C2440: 'return' : cannot convert from 'lld::elf::MipsGOTSection<ELFT> *' to 'lld::elf::AtomSection<ELFT> *'
>         with
>         [
>             ELFT=lld::elf::Mips32ELType
>         ]
>         Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
>
> I think this regressed caused in 234727: that the forward-declarations
> of MipsGOTSection<> is not enough.

Thanks for the fix.

-- 
Simon Atanasyan



More information about the llvm-commits mailing list