[lld] r234736 - Speculative build fix for lld on Windows

Hans Wennborg hans at hanshq.net
Mon Apr 13 04:00:23 PDT 2015


Author: hans
Date: Mon Apr 13 06:00:22 2015
New Revision: 234736

URL: http://llvm.org/viewvc/llvm-project?rev=234736&view=rev
Log:
Speculative build fix for lld on Windows

I can't access my Windows machine at the moment, but the build was breaking with:

c:\b\build\slave\crwinclanglld\build\src\third_party\llvm\tools\lld\lib\readerwriter\elf\mips\MipsTargetLayout.h(38) : error C2440: 'return' : cannot convert from 'lld::elf::MipsGOTSection<ELFT> *' to 'lld::elf::AtomSection<ELFT> *'
        with
        [
            ELFT=lld::elf::Mips32ELType
        ]
        Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast

I think this regressed caused in 234727: that the forward-declarations
of MipsGOTSection<> is not enough.

Modified:
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsSectionChunks.h
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsTargetLayout.h

Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsSectionChunks.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsSectionChunks.h?rev=234736&r1=234735&r2=234736&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsSectionChunks.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsSectionChunks.h Mon Apr 13 06:00:22 2015
@@ -10,6 +10,7 @@
 #define LLD_READER_WRITER_ELF_MIPS_MIPS_SECTION_CHUNKS_H
 
 #include "MipsReginfo.h"
+#include "SectionChunks.h"
 
 namespace lld {
 namespace elf {

Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsTargetLayout.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsTargetLayout.h?rev=234736&r1=234735&r2=234736&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsTargetLayout.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsTargetLayout.h Mon Apr 13 06:00:22 2015
@@ -9,14 +9,12 @@
 #ifndef LLD_READER_WRITER_ELF_MIPS_MIPS_TARGET_LAYOUT_H
 #define LLD_READER_WRITER_ELF_MIPS_MIPS_TARGET_LAYOUT_H
 
+#include "MipsSectionChunks.h"
 #include "TargetLayout.h"
 
 namespace lld {
 namespace elf {
 
-template <typename ELFT> class MipsGOTSection;
-template <typename ELFT> class MipsPLTSection;
-template <typename ELFT> class MipsRelocationTable;
 class MipsLinkingContext;
 
 /// \brief TargetLayout for Mips





More information about the llvm-commits mailing list