[PATCH] [SCEV] Extract and strengthen isHighCostExpansion.

Justin Bogner mail at justinbogner.com
Mon Apr 13 01:41:53 PDT 2015


On Sunday, April 12, 2015, Sanjoy Das <sanjoy at playingwithpointers.com>
wrote:

> > It's kind of nice to move code in a separate change from updating it, so
> > that it's easier to see what actually changed.
>
> Done.  The NFCI part is in D8995.


Thanks.


> > We don't usually repeat the function name in the doc comment for new
> > code.
>
> I went with it since that is the convention in the rest of the file.
> If it is okay with you, I'd prefer fixing this by submitting this
> change as is and fixing the whole ScalarEvolutionExpander.h file at
> once in an NFC commit.


Sure.


>  Also, I could not easily find this in
> CodingStandards.html -- should this clause be added there?
>
> -- Sanjoy
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150413/37608785/attachment.html>


More information about the llvm-commits mailing list