[PATCH] Fix LLVM_OPTIMIZED_TABLEGEN CMake option

Chris Bieneman beanz at apple.com
Fri Apr 10 14:32:44 PDT 2015


Ok, it is a well established fact that my memory sucks...

I still don't disagree with this being a bug. I just disagree with how you're fixing it.

Your fix passes the flag not just if the directory doesn't exist, but also if it is out-of-date. Meaning, while this does fix your problem, it also changes functionality. I'd prefer a solution that didn't change the behavior.

Setting build type when creating the directory is ok, but we shouldn't override it if it was already set.


http://reviews.llvm.org/D8981

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list